Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(optimizeDeps): added @accordproject/template-engine to vite optimizeDeps to speed up cold start #108

Merged
merged 1 commit into from
Sep 27, 2024
Merged

fix(optimizeDeps): added @accordproject/template-engine to vite optimizeDeps to speed up cold start #108

merged 1 commit into from
Sep 27, 2024
+2 −0

Conversation

Vinyl-Davyl
Copy link
Collaborator

Fix

This pull request optimizes the build performance of the project by addressing the Vite warning regarding mixed ESM and CJS modules.

Changes

  • Added the package @accordproject/template-engine to optimizeDeps.needsInterop in vite.config.js to improve cold start performance.
  • This change aims to enhance the build performance and reduce the likelihood of encountering mixed module issues during development.

Author Checklist

  • Ensure you provide a DCO sign-off for your commits using the --signoff option of git commit.
  • Vital features and changes captured in unit and/or integration tests
  • Commits messages follow AP format
  • Extend the documentation, if necessary
  • Merging to main from fork:branchname

@Vinyl-Davyl Vinyl-Davyl requested a review from a team as a code owner September 26, 2024 05:02
@netlify Netlify
Copy link

netlify bot commented Sep 26, 2024 •
edited
Loading

✅ Deploy Preview for ap-template-playground ready!

Name Link
🔨 Latest commit f14310d
🔍 Latest deploy log https://app.netlify.com/sites/ap-template-playground/deploys/66f4eb0754301f00071957df
😎 Deploy Preview https://deploy-preview-108--ap-template-playground.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Vinyl-Davyl
update: development
f14310d 
Signed-off-by: Vinyl-Davyl <[email protected]>
@mttrbrts mttrbrts merged commit 460922f into accordproject:main Sep 27, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mttrbrts mttrbrts mttrbrts approved these changes

@sanketshevkar sanketshevkar Awaiting requested review from sanketshevkar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Vinyl-Davyl @mttrbrts